Fix isPressed for ButtonConfiguration #537
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffried
commented
Jul 19, 2023
| @@ -103,7 +103,7 @@ public struct _Button<Label>: View where Label: View { | |||
| public let action: () -> () | |||
|
|
|||
| @State | |||
| public var isPressed = false | |||
| public var isPressed: (down: Bool, inside: Bool) = (false, false) | |||
There was a problem hiding this comment.
I'm not sure about the public api here. It's a breaking change in theory, but AFAIK _Button should only be used internally.
|
@carson-katri I've fixed a small bug in my first implementation (re-entering the button while holding the mouse down didn't work correctly). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #534.